-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(datastore): adds in, not-in, and != query operators #6017
Conversation
Co-authored-by: Tyler Bui-Palsulich <26876514+tbpg@users.noreply.github.com>
Co-authored-by: Tyler Bui-Palsulich <26876514+tbpg@users.noreply.github.com>
Per @kolea2 : Be sure to add integration tests |
Logged #6184 to track enabling the integration tests for this feature. |
Hi, thanks for releasing this feature. Is it possible that we could change the signature of the baseQuery.FilterField("I", "not-in", []interface{}{1, 3, 5, 7})
baseQuery.FilterField("I", "not-in", 1, 3, 5, 7) As for equality queries, we can take the first element of the value, or panic if there is no given value. |
Hi @lixin9311 ! Thank you for your message. In the future, it's probably best to log an issue in the repo to ask for a feature request. That said, I don't think that I'll accept your requested change. I think that adding a variadic value to account for array values isn't going to be useful for most customers. |
This PR was previously merged and then reverted.
Waiting for feature to be launched.